fix: handled theming for instrument screens#2732
Merged
Merged
Conversation
Contributor
|
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/15635232992/artifacts/3322685692 |
Yugesh-Kumar-S
added
flutter
Status: Review Required
Contributor
|
@Yugesh-Kumar-S This is fine. Let's just keep the default color of the light mode for the sliders both in the light and the dark mode. By default in the light mode, the color isn't black. Let's keep that color instead. |
Contributor
Author
|
AsCress
changed the title
Contributor
|
@Yugesh-Kumar-S This one is good to go. Just resolve conflicts here. |
AsCress
approved these changes
Jun 13, 2025
Yugesh-Kumar-S
added a commit
to Yugesh-Kumar-S/pslab-android
that referenced
this pull request
Jun 13, 2025
# This is the 1st commit message: Implemented LUX meter # This is the commit message #2: added const # This is the commit message fossasia#3: Improved responsiveness and made reusable widgets # This is the commit message fossasia#4: renamed file # This is the commit message fossasia#5: Updated view as per PSLab # This is the commit message fossasia#6: Implemented sound meter # This is the commit message fossasia#7: feat: implemented LUX meter (fossasia#2733) fix: handled theming for instrument screens (fossasia#2732) chore(deps): bump org.jetbrains.kotlin.android in /android Bumps [org.jetbrains.kotlin.android](https://github.com/JetBrains/kotlin) from 1.8.22 to 2.1.21. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.8.22...v2.1.21) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.android dependency-version: 2.1.21 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Adjusted view Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2705
Changes
Screenshots / Recordings
Screen_recording_20250610_191028.mp4
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard coding any value.strings.xml,dimens.xmlorcolors.xml.